feat: add custom auth options to ecosystem settings #5075
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5075 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1059 1059
Lines 54728 54728
Branches 3954 3954
=======================================
Hits 24791 24791
Misses 29246 29246
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
joaquim-verges
force-pushed
the
feat_add_custom_auth_options_to_ecosystem_settings
branch
from
b65259c to
53c2997
Compare
...)/dashboard/connect/ecosystem/[slug]/(active)/components/client/auth-options-form.client.tsx
Outdated
Show resolved
Hide resolved
joaquim-verges
force-pushed
the
feat_add_custom_auth_options_to_ecosystem_settings
branch
from
53c2997 to
0157834
Compare
| onError: (error) => { | ||
| const message = | ||
| error instanceof Error ? error.message : "Failed to update ecosystem"; | ||
| toast.error(message); | ||
| }, | ||
| onSuccess: () => { | ||
| toast.success("Custom Auth Options updated"); | ||
| }, |
There was a problem hiding this comment.
this can be improved to use toast.promise etc @MananTank or @kien-ngo maybe you can clean it up down the line - for now this is fine
Merge activity
|
## Problem solved  <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `Ecosystem` type and its related components by adding support for custom authentication options, including headers and endpoints, and updating the mutation logic to accommodate these changes. ### Detailed summary - Added `customAuthOptions` to the `Ecosystem` type. - Updated `useUpdateEcosystem` to accept `Ecosystem` directly. - Modified mutation logic to handle the new `Ecosystem` structure. - Introduced `CustomAuthOptionsForm` for managing custom authentication endpoints and headers. - Enhanced UI components to reflect new functionality. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
joaquim-verges
force-pushed
the
feat_add_custom_auth_options_to_ecosystem_settings
branch
from
c324cf9 to
0f4e662
Compare
graphite-app
bot
deleted the
feat_add_custom_auth_options_to_ecosystem_settings
branch
Problem solved
PR-Codex overview
This PR enhances the
Ecosystemtype by adding support for custom authentication options. It updates theuseUpdateEcosystemhook to use the new structure and modifies theAuthOptionsFormcomponent to manage these options, including a newCustomAuthOptionsForm.Detailed summary
customAuthOptionsto theEcosystemtype.useUpdateEcosystemto accept the newEcosystemstructure.AuthOptionsFormfor handling authentication options.CustomAuthOptionsFormfor custom authentication endpoint management.